Fix mypy to 0.812 for now #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 49 49
Lines 1954 1954
=======================================
Hits 1733 1733
Misses 221 221 Continue to review full report at Codecov.
|
artursouza
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like mypy == 0.900 released some breaking changes. We can fix them with --install-types, however this blocks the terminal with a prompt (see python/mypy#10616 ). We'll have to let upstream add a --non-interactive option (coming in 0.910) before we can use this. Leaving at 0.812 fixes our build for now.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #225
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: